Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (tabs) move to next tab if moving to next pane from fullscreen pane #3498

Merged

Conversation

VasilisManol
Copy link
Contributor

fixes #3434

@VasilisManol VasilisManol marked this pull request as ready for review July 14, 2024 09:40
@imsnif
Copy link
Member

imsnif commented Oct 25, 2024

Hey, circling back to this (thank you for your patience!) - I tested this out and found a slight issue: this only works to change to the next tab if the original pane was on the side of the screen. Otherwise the first move action doesn't do anything (behind the scenes it switches to the next pane, but the user doesn't see anything because it's hidden) and only then it switches to the next tab.

If you want to fix this, I'll be happy to take another look and merge.

@VasilisManol
Copy link
Contributor Author

Hey, I can't reproduce this. I tried with a horizontal layout with 5 panes. 1 at the row on top and 4 at the row below. Even If I start at one pane in the second row in between and switch to right the correct pane comes to fullscreen and changes.
Did you mean such a case or did I got you wrong?

@imsnif
Copy link
Member

imsnif commented Oct 25, 2024

Oh, wait - sorry! This was a misunderstanding on my part. When in this situation as you describe, the focus first switches to the other pane in the same tab (which then turns full screen) and then when it reaches the edge, to the other tab. I wasn't seeing this because I tested this with all panes being identical. My bad!

I don't know why we don't see CI running in this PR (probably because it's quite old). I'm going to run the tests locally on this branch and if they pass I'll merge - otherwise we can troubleshoot things here.

@imsnif
Copy link
Member

imsnif commented Oct 25, 2024

Everything's green. Thanks for putting this together and once again, thanks for your patience!

@imsnif imsnif merged commit 9a2f909 into zellij-org:main Oct 25, 2024
Tomcat-42 pushed a commit to Tomcat-42/zellij that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MoveFocusOrTab does not switch tab when a pane is in fullscreen
2 participants